Yup.
> >Richard Gooch wrote:
> >> However, if there was some compiler trickery we could employ such that
> >> a VFS change doesn't require source code to be touched, it would be a
> >> good idea. Being able to strip those method existence tests would make
> >> code a bit more readable and would also save a few cycles. But I don't
> >> see how to do it without making drivers not distributed with the
> >> kernel much harder to maintain.
>
> One way of "fixing" this for most cases might be to let register_chrdev
> call a function fixup_fops() like this:
>
> void fixup_fops(struct file_operations *fops)
> {
> if (!fops->llseek) fops->llseek = dummy_llseek;
> if (!fops->read) fops->llseek = dummy_read;
> if (!fops->write) fops->llseek = dummy_write;
> ...
> }
That idea has some appeal. We can't rely on it, though, because there
are plenty of drivers which substitute the methods structure at some
point, and then sometimes later restore the methods.
Regards,
Richard....
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.altern.org/andrebalsa/doc/lkml-faq.html