Re: linux-2.1.119 + l-con118

Alexander V. Lukyanov (lav@long.yar.ru)
Fri, 4 Sep 1998 01:46:06 +0400

On Wed, Sep 02, 1998 at 01:06:04AM +0400, I wrote:
> I tried the new console patch, and noticed that clearing margins still
> does not work.
>
> It appears that yres_virtual is adjusted for the font height (in
> fbcon.c:1314), and then clear_margins method (fbcon-cfb8.c:236) uses it to
> calculate the margin (bottom_width). So the margin is always calculated as
> 0.

Here is a patch which fixes the problem for me. I really don't know if
it has any side effects, but I'm also puzzled why it is needed to change
virtual resolution - the parameter seems very hardware related.

btw, I'm using vesafb - forgot to mention it in last message.

To reproduce the not-clearing of margins, I use 1024x768x8 mode
and set SUN12x22 font on one console and VGA8x16 on other, and when switching
between them I have uncleared field at the bottom of screen.

--- fbcon.c.1 Fri Sep 4 01:29:30 1998
+++ fbcon.c Fri Sep 4 01:29:52 1998
@@ -1311,7 +1311,7 @@
if (!p->dispsw->set_font ||
!p->dispsw->set_font(p, fontwidth(p), fontheight(p))) {
/* Adjust the virtual screen-size to fontheight*rows */
- p->var.yres_virtual = (p->var.yres/h)*h;
+/* p->var.yres_virtual = (p->var.yres/h)*h;*/
}
p->vrows = p->var.yres_virtual/h;
updatescrollmode(p);

Alexander.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.altern.org/andrebalsa/doc/lkml-faq.html