Re: DOS directory delete bug in 2.0.34/35

andi@muenchen.roses.de
Wed, 9 Sep 98 03:42 GMT


: I have experienced a problem in both 2.0.34 and 2.0.35 when
: deleting an MS-DOS directory from Linux:

: Even if the directory isn't empty, Linux will delete it straight
: away. And if I boot into DOS and do a Scandisk, I will get
: a message about bogus data not belonging to any files (exactly
: the size of the flies in the directory in question)

: This doesn *not* happen with 2.0.33, that's for sure.

Can't believe that, but it is true. Anyway, the cure is simple,
somebody forgot a pair of braces.

Regards

Andreas

--- old/linux/fs/msdos/namei.c Wed Sep 9 03:05:55 1998
+++ linux/fs/msdos/namei.c Wed Sep 9 03:06:42 1998
@@ -369,7 +369,7 @@
if (MSDOS_I(dir)->i_start) { /* may be zero in mkdir */
pos = 0;
bh = NULL;
- while (fat_get_entry(dir,&pos,&bh,&de) > -1)
+ while (fat_get_entry(dir,&pos,&bh,&de) > -1) {
/* Ignore vfat longname entries */
if (de->attr == ATTR_EXT)
continue;
@@ -379,6 +379,7 @@
fat_brelse(sb, bh);
return -ENOTEMPTY;
}
+ }
if (bh)
fat_brelse(sb, bh);
}

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/faq.html