Re: [PATCH] APM 2.0.35 and 2.1.120 (was: Fix for oops at system halt)

Jan Echternach (echter@informatik.uni-rostock.de)
Wed, 9 Sep 1998 16:05:19 +0200


On Tue, Sep 08, 1998 at 06:25:10PM +0100, Alan Cox wrote:
> Ive dropped this into 2.0.36 for pre9. The only difference is I
> put the apm_enabled check into apm_set_power_state

Is there any specific reason you've done this? It looks like those
apm_set*/get* functions are intended for internal use only, and that
the bug came from declaring one of them public instead of writing a
proper wrapper function that checks for apm_enabled and handles APM
error codes. Also note that all other calls to apm_set_power_state()
don't need the check there, as apm_enabled == 1 is already guaranteed
in those cases. Therefore I suggest you use Stephen's patch, which is
much cleaner.

-- 
Jan

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/faq.html