Again, great work. :-) I haven't tested it yet, but will be doing so
tonight when I get done work.
I whipped up a -very- quick patch to eliminate some -Wall warnings that
devfsd kicked up (yeah, I'm anal that way ;-). GCC should have optimized
most of this away anyway, but it's nice doing a compile with -Wall and not
seeing a single warning. :-)
Thanks for the great work on devfs. Has Linus expressed whether devfs will
actually be going into 2.2 (I know he mentioned he was going to evaluate
it, but that's the last I heard)?
-- -------------------. emarshal at logic.net .--------------------------------- Edward S. Marshall `-----------------------' http://www.logic.net/~emarshal/Linux labyrinth 2.1.117 #2 SMP Thu Aug 20 21:20:49 CDT 1998 i586 unknown 9:50am up 2 days, 22:46, 3 users, load average: 0.43, 0.28, 0.18
diff -u devfsd.old/Makefile devfsd/Makefile --- devfsd.old/Makefile Mon Aug 10 23:26:40 1998 +++ devfsd/Makefile Thu Sep 10 09:55:58 1998 @@ -1,8 +1,12 @@ +CC=gcc +CFLAGS=-O3 -Wall +LDFLAGS=-s + + all: devfsd clean devfsd: devfsd.c - cc -s -o devfsd devfsd.c $(CFLAGS) clean: diff -u devfsd.old/devfsd.c devfsd/devfsd.c --- devfsd.old/devfsd.c Thu Sep 10 08:02:12 1998 +++ devfsd/devfsd.c Thu Sep 10 09:51:22 1998 @@ -45,6 +45,8 @@ #include <sys/time.h> #include <sys/stat.h> #include <sys/types.h> +#include <sys/ioctl.h> +#include <sys/wait.h> #include <unistd.h> #include <dirent.h> #include <fcntl.h> @@ -222,7 +224,8 @@ */ { int err; - char *ptr, *line; + char *ptr; + char *line = NULL; struct config_entry *new; FILE *fp; char buf[STRING_LENGTH], p1[STRING_LENGTH], p2[STRING_LENGTH]; @@ -321,7 +324,6 @@ { ssize_t bytes; struct devfsd_notify_struct info; - char type[STRING_LENGTH]; while ( ( bytes = read (fd, (char *) &info, sizeof info) ) >= 0 ) {
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/faq.html