apm broken - again (2.1.122) + FIX

Marc Lehmann (pcg@goof.com)
Thu, 17 Sep 1998 14:26:03 +0200

On one sunny day, somebody disabled APM+SMP, causing kernel oopses everytime
I try to switch of my machine (using apm). The stated reason was (I believe),
that APM does not work with SMP. But fact is:

- APM poweroff works fine here when APM+SMP is enabled
- APM poweroff causes an oops with the current apm.c

I "fixed" it by commenting out the first "return;" in apm_bios.c, send a bug
report to the kernel list, and forgot about it.

Now, it wasn't fixed, but 2.1.122 reintroduced it (not really, 2.1.122 just
renamed apm_bios.c)

So, again, what purpose has this code in apm.c:

#ifdef __SMP__
if (smp_num_cpus > 1) {
printk(KERN_NOTICE "APM disabled: APM is not SMP safe.\n");
return;
}
#endif

with it, I get oopses, without it everything works fine. Yes, I'm not
enabling any powersaving, I just want an automatic power-off, and the
current code is (and was) buggy.

-----==- |
----==-- _ |
---==---(_)__ __ ____ __ Marc Lehmann +--
--==---/ / _ \/ // /\ \/ / pcg@goof.com |e|
-=====/_/_//_/\_,_/ /_/\_\ --+
The choice of a GNU generation |
|

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/