Re: [patch] Re: [PATCH] modules_install

Alan Cox (alan@lxorguk.ukuu.org.uk)
Mon, 5 Oct 1998 03:26:31 +0100 (BST)


> + TMPDIR="/tmp/kernel.tmp.$$$$"; \
> + rm -rf $$TMPDIR; \

What if this is a symlink ????

> + umask 022; \
> + mkdir $$TMPDIR; \
> + if [ $$? -ne 0 ]; then \
> + echo "$0: Can't create temp dir $$TMPDIR, exiting..."; \
> + exit 1; \
> + fi; \

And this is a denial of service attack

Just back the patch out. Its a complete turkey. If you want to fix it
you need additional tools like mktemp which not all distributions include

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/