Re: [PATCH] NIPQUAD macro broken on big endian

David S. Miller (davem@dm.cobaltmicro.com)
Wed, 7 Oct 1998 02:51:09 -0700


From: Andreas Schwab <schwab@issan.informatik.uni-dortmund.de>
Date: 07 Oct 1998 11:09:08 +0200

The NIPQUAD makro is broken on big endian machines. The argument is a
number in network byte order.

Now it is slow as shit on little endian, what is your point with this
patch?

Linus isn't going to accept this, and I know why. Why not define it
conditionally based upon endianness, changing the shifts and masks to
match, instead of unnecessarily bloating things with ntohl()
etc. calls in one case for the sake of correctness on another?

Later,
David S. Miller
davem@dm.cobaltmicro.com

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/