Re: [PATCH] NIPQUAD macro broken on big endian
Geert Uytterhoeven (Geert.Uytterhoeven@cs.kuleuven.ac.be)
Wed, 7 Oct 1998 13:15:07 +0200 (CEST)
On Wed, 7 Oct 1998, David S. Miller wrote:
> From: Andreas Schwab <schwab@issan.informatik.uni-dortmund.de>
> Date: 07 Oct 1998 12:48:00 +0200
>
> "David S. Miller" <davem@dm.cobaltmicro.com> writes:
>
> |> Now it is slow as shit on little endian, what is your point with this
> |> patch?
>
> My point is to make it work, nothing more and nothing less. Of course, it
> doesn't *have* to be slow on little endian if the ntohl macro is properly
> written so that gcc can combine the shifts inside and outside of it.
>
> I know this, and I sent your original patch to Linus long ago, and I
> am telling you his response and his reasoning. At least I gave you a
> suggestion for an implementation which would have a greater chance at
> accpetance :-)
Do I read this correct?!? Is it more acceptable to have a bug[*], than a not
optimal fix?!?!?
Greetings,
Geert
[*] OK, only on `exotic' platforms ;-)
--
Geert Uytterhoeven Geert.Uytterhoeven@cs.kuleuven.ac.be
Wavelets, Linux/{m68k~Amiga,PPC~CHRP} http://www.cs.kuleuven.ac.be/~geert/
Department of Computer Science -- Katholieke Universiteit Leuven -- Belgium
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/