Re: [PATCH] NIPQUAD macro broken on big endian

Linus Torvalds (torvalds@transmeta.com)
Wed, 7 Oct 1998 09:10:12 -0700 (PDT)


On 7 Oct 1998, Andreas Schwab wrote:
>
> The NIPQUAD makro is broken on big endian machines. The argument is a
> number in network byte order.

Stop sending me this patch. I've rejected it before, for good reason.

Remember: I don't reject patches just because I drop them. I often reject
patches because they are obviously bad. This is one.

If you want to send me a patch to clean it up, make sure that it doesn't
generate ridiculously more code on the 99% of Linux machines that have a
sane byte order.

Solutions I can accept:
- move it into byteorder.h and make it dependent on the byte order
- use "cpu_to_le32()" instead of ntohl() so that the common case doesn't
have extra overhead.

Linus

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/