Re: [PATCH] NIPQUAD macro broken on big endian

Linus Torvalds (torvalds@transmeta.com)
8 Oct 1998 15:50:58 GMT

Messages sorted by: [ date ][ thread ][ subject ][ author ]
Next message: Simon Kenyon: "Re: UDI and Free Software"
Previous message: Zhu Ming: "Re: ip_build_header() vs ip_build_xmit()"

In article <C1256696.00797703.00@do-notes01.ExperTeam.de>,
Roderich Schupp <rsch@ExperTeam.de> wrote:
>Linus Torvalds <torvalds@transmeta.com> said:
>> - it's not so much slowness as code expansion (NIPQUAD is only used
>> by various printk's, so performance per se is secondary)
>
>So why not teach the kernel's vsprintf a new format code and
>get rid of this hack? (Wasn't such a format in the kernel at one time?)

There was.

I got rid of it, because it's unusable. It means that you can't have gcc
warn about printf() misuses, and they are a lot more important to me
than adding a random format code.

Linus

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/

Next message: Simon Kenyon: "Re: UDI and Free Software"
Previous message: Zhu Ming: "Re: ip_build_header() vs ip_build_xmit()"