Sound OOPS in sgalaxy + patch

Oleg Drokin (green@ccssu.crimea.ua)
Sat, 10 Oct 1998 12:59:50 +0400 (MSD)


Hello!

I've just found that if we try to load Sound Galaxy module
with incorrect 'irq' parameter (not one of 7,9,10 or 11) then we get
an OOPS and sgalaxy module stuck in unitialized state with usage
count of 1. (e.g. modprobe sgalaxy io=0x530 irq=5 dma=0 sgbase=0x220)
Reboot is needed to make another try. 2.1.125 and previous
versions affected. The same problem exists in CS4232 (in 2.0.X too),
but I do not have such card, so I did not include fix for it, as I
cannot check it.
OOPS is due to lack of checks in probe_sgalaxy. probe_ms_sound does
a lot more of sanity checks.
1st patch included is fix for the OOPS and works fine for me and my
friends.

The second problem is whenever I give correct irq parameter to
sgalaxy, it complains (actually ad1848) about '[MSS: IRQ Conflict?]'
and if I give wrong irq it does not complains.
Can someone check is the second patch correct, or is this should be
done only for Sound Galaxy cards?

IRQ OOPS fix:

begin 644 irq_oops_fix.diff.gz
M'XL("-@?'S8``VER<5]O;W!S7V9I>"YD:69F`*51/6_",!"=XU]Q8\!Q/B`2
MD$A5Q@ZH'=HN72QCFV`UC:GM(%#%?Z^3%"2DJAWJP=:]\[M[]XX0`HUJNV,B
MC#I(8Q.KNU8DMF8-.YYB'FNCZN").7CD#K(4LJQ(\V(^@VRU6B*,\>_\&^JL
MR!?%;#Y2JPK(:AXM``]W52$(S@@NQT=J"R$PD2WS)1722>Y\J,B=TG3#K,1Y
M!`\OZW4T@-KN80(31(+`2->9%K(R^*Z53.%Y)X$S(T!98(V13)R`<><UPS1!
M^$K:&[V1]-W288Z0J4GY!S\"OI/\#93Y`.EX',=]Q:O^(4F-K)5N1_E,45OW
M`T20'KTMO6H(/@=#LBR-/(3[=_3$IVPCY3Z$^]>D_UUZC/S?&T00&=VY8&F)
M\"WR@QD(SKVF@U8"F'.,[^CWKD.PSG1^TTP((ZVEJMUJF#+E&W\!&D08*V<"
"``#R
`
end

Fix for wrong complains from ad1848:

begin 644 complains_fix.diff.gz
M'XL("(X''S8``V-O;7!L86EN<U]F:7@N9&EF9@"%CD%+PT`0A<_97_'L039N
MM]FM*:8IQ8#T(*)B<E0I3=*6P;);-AOI0?^[J^W)@QZ&&9COXSTI)79D^D/2
M.GI?NR[I;&_:9-7J+,U&S<@ZVD;5RN.Q\=`*6N=JDH]3Z.DT8T*(/_7?ILK5
MR2P*R/'E1`^O($Z[*!BBR*U][\PLG)]A;.]KSFOR'3Z@#JF*AVBLV=!VN;?.
MQS,F(]J`<S(U_RY`UAP_.#_RF,^A8B;^P\Y^L%!@[\CX-WZW*!^6B[+$X/F^
>JG+<ED^X"<D[:OSUZXL9A&PP)!?L"X`2Q/)$`0``
`
end

Bye,
Oleg

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/