Re: 2.1.127pre2

David S. Miller (davem@dm.cobaltmicro.com)
Mon, 26 Oct 1998 23:12:34 -0800


Date: Tue, 27 Oct 1998 01:33:16 -0500 (EST)
From: Wes Morgan <by-tor@by-tor.tacorp.net>

This is far from an EGCS bug, it's my fault actually...

make[2]: Entering directory `/usr/src/linux/drivers/misc'
gcc -D__KERNEL__ -I/usr/src/linux/include -Wall -Wstrict-prototypes -O2
-fomit-frame-pointer -pipe -fno-strength-reduce -mpentium -malign-loops=2
-malign-jumps=2 -malign-functions=2 -DCPU=586 -DMODULE -DMODVERSIONS
-include /usr/src/linux/include/linux/modversions.h -c -o
parport_share.o parport_share.c
parport_share.c: In function `parport_register_port_R36e2f16b':
parport_share.c:108: parse error before `{'

Linus, can we have a "rwlock_init()" just like we do for spinlocks so
functions can initialize rwlock's in this manner without the compile
bombing on non-SMP because it will in turn from:

tmp->foo_rwlock = RWLOCK_INIT;

end up seeing:

tmp->foo_rwlock = { };

which last time I checked is not legal C :-)

Even better we can do away with this empty structure frivolity in the
spinlock.h implementation headers, your choice.

Later,
David S. Miller
davem@dm.cobaltmicro.com

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/