Re: [PATCH] ad1848 doesn't correctly free IRQ on unloading --> oops.

Philip Blundell (philb@gnu.org)
Thu, 29 Oct 1998 21:28:16 +0000

>ad1848 registers the irq with devc->dev_no as the 'instance data' or whatever
>it's called. Later it tries to free it, just passing NULL.

Incidentally, I think the "if (irq > 0)" test there should probably be "if
(devc->irq > 0)". Otherwise the driver still tries to free the irq if it
failed to claim it.

> if (!share_dma)
> {
> if (irq > 0)
>- free_irq(devc->irq, NULL);
>+ free_irq(devc->irq, (void *)devc->dev_no);

p.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/