Re: Weird TCP CLOSE state behavior

Philip Gladstone (philip@raptor.com)
Wed, 04 Nov 1998 09:26:46 -0500


This is a cryptographically signed message in MIME format.

--------------ms40520D5E9CB9C3C19BB3B72B
Content-Type: multipart/mixed; boundary="------------4C09EEA8054EEF81211A28B1"

This is a multi-part message in MIME format.
--------------4C09EEA8054EEF81211A28B1
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit

Jason,
I find that the attached patch works wonders for me. This is
against 2.0.35pre16, but it should apply to somewhat earlier versions.
I think that this patch is in the queue for 2.0.37, but Alan did not
deem this bug serious enough for 2.0.36.

Philip

Jason Gunthorpe wrote:
>
> [Please CC, I'm not on the list]
>
> Hi,
>
> I'm seeing some strange behavoir with some rsync processes. They somehow
> manage to get their connection stuck in the CLOSE state and never die, I
> now have some that have been sitting around for almost two days! I
> discussed the matter with Andrew and there is some speculation that it may
> be some weird kernel problem, here are the details..

-- 
Philip Gladstone                           +1 781 530 2461
Raptor Systems / Axent Technologies 
Waltham, MA                         http://www.raptor.com/
--------------4C09EEA8054EEF81211A28B1
Content-Type: text/plain; charset=us-ascii; name="p2_select.rpf"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline; filename="p2_select.rpf"

--- olinux/net/ipv4/tcp.c Wed Aug 5 13:58:44 1998 +++ linux/net/ipv4/tcp.c Wed Aug 5 13:51:45 1998 @@ -951,6 +951,7 @@ return 0; - if (sk->state == TCP_SYN_SENT || sk->state == TCP_SYN_RECV) - break; + /* Check do_tcp_sendmsg for this next line */ + if (sk->state != TCP_ESTABLISHED && sk->state != TCP_CLOSE_WAIT) + break; if (sk->wmem_alloc*2 > sk->sndbuf) break; return 1;

--------------4C09EEA8054EEF81211A28B1--

--------------ms40520D5E9CB9C3C19BB3B72B Content-Type: application/x-pkcs7-signature; name="smime.p7s" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="smime.p7s" Content-Description: S/MIME Cryptographic Signature

MIIIcQYJKoZIhvcNAQcCoIIIYjCCCF4CAQExCzAJBgUrDgMCGgUAMAsGCSqGSIb3DQEHAaCC BicwggLXMIICQKADAgECAgIwtDANBgkqhkiG9w0BAQQFADCByDELMAkGA1UEBhMCWkExFTAT BgNVBAgTDFdlc3Rlcm4gQ2FwZTEUMBIGA1UEBxMLRHVyYmFudmlsbGUxGjAYBgNVBAoTEVRo YXd0ZSBDb25zdWx0aW5nMTMwMQYDVQQLEypDZXJ0aWZpY2F0ZSBTZXJ2aWNlcyBSU0EgSUsg MTk5OC4yLjI1IDg6MzUxOzA5BgNVBAMTMlRoYXd0ZSBQZXJzb25hbCBGcmVlbWFpbCBSU0Eg SXNzdWluZyBLZXkgMTk5OC4yLjI1MB4XDTk4MDgxMjE0NDIyOVoXDTk5MDgxMjE0NDIyOVow QzEfMB0GA1UEAxMWVGhhd3RlIEZyZWVtYWlsIE1lbWJlcjEgMB4GCSqGSIb3DQEJARYRcGhp bGlwQHJhcHRvci5jb20wgZ8wDQYJKoZIhvcNAQEBBQADgY0AMIGJAoGBAONqzM373SGsMZ5C X1WU1vOr8pZFVRBVJC/WEfc5sR+Q4YAjRk5F4Yww6cHAXtTiptaSWcgK+dli46/5Sy60UX2s iVcl8i6pmcQ/m+kFodrJ1GjZd9SU2+IMnY7liBP2sdwAB02G9EX2B43nAh9/Y2Xl4T8uGV3L oz6CwP5YmUV1AgMBAAGjVDBSMBEGCWCGSAGG+EIBAQQEAwIFoDAOBgNVHQ8BAf8EBAMCBaAw DAYDVR0TAQH/BAIwADAfBgNVHSMEGDAWgBTtNBduDiteS4eYkbg3p5i/kh+scjANBgkqhkiG 9w0BAQQFAAOBgQBZPzaRk5KnLZCwvJy/y/OaSAfGp1h/c8agEBoLclt3CSytNnT3FVZLq5w/ R0O9wIu8er/eivXt1CvWs/wYpqZpszhmbaIreRZHY9A93G/Zavv7yyMBpK5OVYpkAMUt4rAc 7/twlNMo/493FEBSAiYjdbhIqGOyBikq/R3iyFiyUjCCA0gwggKxoAMCAQICAQgwDQYJKoZI hvcNAQEEBQAwgdExCzAJBgNVBAYTAlpBMRUwEwYDVQQIEwxXZXN0ZXJuIENhcGUxEjAQBgNV BAcTCUNhcGUgVG93bjEaMBgGA1UEChMRVGhhd3RlIENvbnN1bHRpbmcxKDAmBgNVBAsTH0Nl cnRpZmljYXRpb24gU2VydmljZXMgRGl2aXNpb24xJDAiBgNVBAMTG1RoYXd0ZSBQZXJzb25h bCBGcmVlbWFpbCBDQTErMCkGCSqGSIb3DQEJARYccGVyc29uYWwtZnJlZW1haWxAdGhhd3Rl LmNvbTAeFw05ODAyMjUwODM1MzNaFw0wMDAyMjUwODM1MzNaMIHIMQswCQYDVQQGEwJaQTEV MBMGA1UECBMMV2VzdGVybiBDYXBlMRQwEgYDVQQHEwtEdXJiYW52aWxsZTEaMBgGA1UEChMR VGhhd3RlIENvbnN1bHRpbmcxMzAxBgNVBAsTKkNlcnRpZmljYXRlIFNlcnZpY2VzIFJTQSBJ SyAxOTk4LjIuMjUgODozNTE7MDkGA1UEAxMyVGhhd3RlIFBlcnNvbmFsIEZyZWVtYWlsIFJT QSBJc3N1aW5nIEtleSAxOTk4LjIuMjUwgZ8wDQYJKoZIhvcNAQEBBQADgY0AMIGJAoGBAMcx w8QbmSNy0lGFlUzjWZLk6GyBtfQbXwnmxK2zRG+qONdX5LDFy7p0rkxhIyR2BvjZXQ2KKLK0 K+0Nu1Ik9LfFSaeDY/wKBLDvgSj35pHGTZfuknYmYshjN3Y8sZIP3K1SBopxxTcxaobbvQhp KFn87cd9JmfdTd7TxQL+d7bhAgMBAAGjNzA1MBIGA1UdEwEB/wQIMAYBAf8CAQAwHwYDVR0j BBgwFqAUcknCczTGVfQLdnKBfnf0h+fGsg4wDQYJKoZIhvcNAQEEBQADgYEAQurti2F+odRc Uqk8vZ6ceegJixKBrY8dWkbt8SUmW8iu/XohFs2gHjuXM4P7TjcqKJemSPUoGAIkfIB7U1C1 +2+a/G2qXCZFqC82IljTGwIDH+6UOfD+NFqISxs9jPPXftOfcFt29tjE4rY8JJ0JJYxZsdSL 8/wEgg6eKYZsxf8xggISMIICDgIBATCBzzCByDELMAkGA1UEBhMCWkExFTATBgNVBAgTDFdl c3Rlcm4gQ2FwZTEUMBIGA1UEBxMLRHVyYmFudmlsbGUxGjAYBgNVBAoTEVRoYXd0ZSBDb25z dWx0aW5nMTMwMQYDVQQLEypDZXJ0aWZpY2F0ZSBTZXJ2aWNlcyBSU0EgSUsgMTk5OC4yLjI1 IDg6MzUxOzA5BgNVBAMTMlRoYXd0ZSBQZXJzb25hbCBGcmVlbWFpbCBSU0EgSXNzdWluZyBL ZXkgMTk5OC4yLjI1AgIwtDAJBgUrDgMCGgUAoIGZMBgGCSqGSIb3DQEJAzELBgkqhkiG9w0B BwEwHAYJKoZIhvcNAQkFMQ8XDTk4MTEwNDE0MjY0N1owIwYJKoZIhvcNAQkEMRYEFCP1Py9k RVeW3Nl6slSsTcDNyBCBMDoGCSqGSIb3DQEJDzEtMCswCgYIKoZIhvcNAwcwDgYIKoZIhvcN AwICAgCAMA0GCCqGSIb3DQMCAgFAMA0GCSqGSIb3DQEBAQUABIGAsAXyl1zcV80zp8uis4Rf p9LCMFmc6lZIKsnjhn27cgasUNYk9KDgyTdPZvvw9DA5HupAh33vFwLQXbMYYiWEFnxHO7Eo lMPEawnRaqU1vZASipsXPg1MUTlywOkSWODIW8mr81wUogTgVmk9oBTuqT61IhgnB7LpPePS HnaeBlc= --------------ms40520D5E9CB9C3C19BB3B72B--

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/