Re: for comment: multi-keyboard patch

Pavel Machek (pavel@atrey.karlin.mff.cuni.cz)
Fri, 6 Nov 1998 14:43:11 +0100


Hi!

> I'm not changing autorepeat behaviour (at least, not deliberately :-).
...
> scheme to do auto-repeat, and it seemed like a good place for that
> functionality.

Yes, it is. Sorry, I confused you with other patch, which also added
autorepeat even for pc keyboard. And yes, having autorepeat in generic
code _is_ good idea.

> > What sense does this piece of code have? I thought that keyboard leds
> > should be independend for each keyboard...
>
> I thought about this. We already have saved led states for each VC.
> I shied off from extending this to saved led states for each VC for
> each keyboard, but maybe that's what we have to do. This would
> probably mean more extensive modifications to stuff like the console
> code, though.

> If we have independent led states for each keyboard, what does it mean
> to do the VC ioctls which set/get the led state? Do they just operate
> on the first keyboard perhaps?

Hmm, there's other problem with led state: ScrollLock is display
local, not keyboard local. Probably we should ignore the issue for
now, and get back once we start modifying consoles.
Pavel

-- 
The best software in life is free (not shareware)!		Pavel
GCM d? s-: !g p?:+ au- a--@ w+ v- C++@ UL+++ L++ N++ E++ W--- M- Y- R+

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/