Re: [patch] my latest oom stuff
Miquel van Smoorenburg (miquels@cistron.nl)
10 Nov 1998 21:53:24 +0100
In article <cistron.199811101421.OAA04435@dax.scot.redhat.com>,
Stephen C. Tweedie <sct@redhat.com> wrote:
>--- linux/include/linux/sysctl.h:1.1.1.3 Sat Oct 31 01:16:09 1998
>+++ linux/include/linux/sysctl.h Sat Oct 31 01:36:44 1998
>@@ -93,7 +93,6 @@
> enum
> {
> /*1*/ VM_SWAPCTL=1, /* struct: Set vm swapping control */
>- VM_SWAPOUT, /* int: Background pageout interval */
> VM_FREEPG, /* struct: Set free page thresholds */
> VM_BDFLUSH, /* struct: Control buffer cache flushing */
> VM_OVERCOMMIT_MEMORY, /* Turn off the virtual memory safety limit */
>
>The problem is that if you do this, you don't just break one single
>sysctl: you break *every single one* in the CTL_VM space, because you
>renumber all of the subsequent sysctl names.
Well why doesn't someone fix all those enums?
enum
{
VM_SWAPCTL=1, /* struct: Set vm swapping control */
VM_SWAPOUT=2, /* int: Background pageout interval */
VM_FREEPG=3, /* struct: Set free page thresholds */
VM_BDFLUSH=4, /* struct: Control buffer cache flushing */
... etc. That would prevent accidents from happening.
Mike.
--
Indifference will certainly be the downfall of mankind, but who cares?
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/