[PATCH] Oops in framebuffer code.

David Woodhouse (David.Woodhouse@mvhi.com)
Fri, 13 Nov 1998 02:26:10 +0000

With vesafb in 2.1.127, there's no fb_pan_display routine set, but fbmem.c
tries to call it upon a FBIOPAN_DISPLAY ioctl without first checking that it's
present. Not good.

Patch not compiled or tested, and it's probably in vger anyway, but what the
hell...

--- fbmem.c.orig Fri Nov 13 02:20:06 1998
+++ fbmem.c Fri Nov 13 02:20:43 1998
@@ -355,7 +355,7 @@
case FBIOPAN_DISPLAY:
if (copy_from_user(&var, (void *) arg, sizeof(var)))
return -EFAULT;
- if ((i=fb->fb_pan_display(&var, PROC_CONSOLE(), info)))
+ if (fb->fb_pan_display && (i=fb->fb_pan_display(&var, PROC_CONSOLE(), info)))
return i;
if (copy_to_user((void *) arg, &var, sizeof(var)))
return -EFAULT;

---- ---- ----
David Woodhouse David.Woodhouse@mvhi.com Office: (+44) 1223 810302
Project Leader, Process Information Systems Mobile: (+44) 976 658355
Axiom (Cambridge) Ltd., Swaffham Bulbeck, Cambridge, CB5 0NA, UK.
finger dwmw2@ferret.lmh.ox.ac.uk for PGP key.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/