2.1.128pre1 patch: Strange use of simple_strtol() in init/main.c

Horst von Brand (vonbrand@sleipnir.valparaiso.cl)
Thu, 12 Nov 1998 22:27:24 -0400


The patch says:

diff -u --recursive --new-file v2.1.127/linux/init/main.c linux/init/main.c
--- v2.1.127/linux/init/main.c Sun Nov 8 14:03:12 1998
+++ linux/init/main.c Sun Nov 8 14:06:18 1998
@@ -377,7 +377,7 @@
int i=1;

while (cur && isdigit(*cur) && i <= 10) {
- ints[i++] = simple_strtoul(cur,NULL,0);
+ ints[i++] = simple_strtol(cur,NULL,0);
if ((cur = strchr(cur,',')) != NULL)
cur++;
}

i.e., change simple_strtoul() for simple_strtol(). The later considers
negative numbers, which is supposed to be the reason for the patch; but the
while loop doesn't consider a '-' sign part of a number?!

-- 
Horst von Brand                             vonbrand@sleipnir.valparaiso.cl
Casilla 9G, Viņa del Mar, Chile                               +56 32 672616

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/