Re: Total freeze with 2.1.12[7,8]

Pascal A. Dupuis (dupuis@lei.ucl.ac.be)
Mon, 16 Nov 1998 12:26:35 +0100 (CET)


On Sat, 14 Nov 1998, Andrea Arcangeli wrote:

> On Fri, 13 Nov 1998, Pascal A. Dupuis wrote:
>
> >The kernel : stock 2.1.128
> >compiled with pgcc, based upon egcs-1.0.3 and -O6: instant freeze
> >same compiler, -O6 and arch/kernel/time.c with -O2 : freeze after
> >mounting the swap file
> >compiled with gcc-2.8.1, -O2 : seems OK
>
> Could you try ftp://e-mind.com/pub/linux/kernel-patches/arca-19-... if
> you' ll have further problems?
>
[context : various locks on a SMP linux, bi-proc machine, mainly when
using Communicator v4.05]

I applied this patch on 2.1.128-ac2. Some parts already applied, one part
I don't understand not applied :

--- linux/arch/i386/kernel/irq.c:1.1.1.1 Fri Oct 2 19:23:36 1998
+++ linux/arch/i386/kernel/irq.c Sat Nov 14 00:31:41 1998
@@ -341,7 +341,7 @@
atomic_read(&global_irq_count), local_irq_count[0],
local_irq_count[1]);
printk("bh: %d [%d %d]\n",
atomic_read(&global_bh_count), local_bh_count[0],
local_bh_count[1]);
- stack = (unsigned long *) &str;
+ stack = (unsigned long *) &stack;
for (i = 40; i ; i--) {
unsigned long x = *++stack;
if (x > (unsigned long) &init_task_union && x < (unsigned
long)
&vsprintf) {

"Stack" is an automatic variable initialised (and untouched) a few lines
before. This patch is asking for troubles... "str" is an argument of the
function, this patch removes any access to it.

Now, the important message is, hum : I don't get locks any more under
netscape ! I browsed three sites, downloding files, clicking as mad
everywhere... not a single locking. It worked beautifully.

OTOH, I still loose the network from times to times. [Intel Etherexpress
Pro10]. Only cure is to remove and reinsert the module.

Greetings

Pascal A. Dupuis

-- 
feature, n: A surprising property of a program.  Occasionaly documented.
To call a property a feature sometimes means the author did not consider
that case, and the program makes an unexpected, though not necessarily
wrong response.  See BUG.  "That's not a bug, it's a feature!"  A bug can
be changed to a feature by documenting it.

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/