Re: patch to drivers/net/8390.c

Jes Sorensen (
01 Dec 1998 10:57:25 +0100

>>>>> "Krzysztof" == Krzysztof G Baranowski <> writes:

Krzysztof> On 30 Nov 1998, Jes Sorensen wrote:
Mikael> 2.1.130 (actually one of the pre-patches) added an unused
Mikael> local variable "ei_local" to
Mikael> drivers/net/8390.c:NS8390_trigger_send(). Since the variable
Mikael> is unused (proof by compilation on x86/UP), I'm assuming this
Mikael> was a mistake. If so, please apply the included patch.

>> And this is wrong! The variable is needed for machines which have
>> the registers for the 8390 memory mapped!

Krzysztof> So there should be a comment explaining this.

Maybe there should but it still doesn't make it correct to revert
other peoples' patches just because one doesn't seem to need it.

Instead of looking at a new kernel release with the 'lets see if we
can get rid of this patch' eyes, it would be nice if some people
applied 'I wonder why this is necessary' strategy and started looking
at the code instead.

Some people seem to have the idea that 'it works for me, obviously it
works for everybody' testing is valid - same thing we saw in the egcs
for 2.0.x discussion.


To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
Please read the FAQ at