Re: [PATCH] Was: patch to drivers/char/serial.c to fix kernel lock-up

Truxton Fulton (trux@truxton.com)
Sun, 6 Dec 1998 14:45:59 -0800 (PST)

It still might not hurt to do more careful manipulation of the IRQ linked
list. There is another line that looks similar to the typo you found.
Is this one a mistake too? (line 1696) :

info->flags = ((state->flags & ~ASYNC_INTERNAL_FLAGS) |

-Truxton

On Sat, 5 Dec 1998, Theodore Y. Ts'o wrote:

> Ah, OK. I found the actual problem, which is a bug in set_serial_info.
> Simply avoiding the IRQ chain would have only hidden the actual
> problem, which was a one-line typo:

> - info->flags = ((state->flags & ~ASYNC_USR_MASK) |
> + info->flags = ((info->flags & ~ASYNC_USR_MASK) |

> This cleared ASYNC_INITIALIZED from info->flags and that's what caused
> startup() to get called twice.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/