Re: m68k softirq.h fix

Graffiti (ramune@bigfoot.com)
Thu, 24 Dec 1998 01:16:31 -0800


On Thu, Dec 24, 1998 at 12:31:00AM +0200, Matti Aarnio wrote:
[snip]
> > -- DN (No, I still have no idea what I'm doing. But it compiles! <g>)
>
> Sure it does compile, but it is wrong.
> See model from AC's patches:
>
> ftp://ftp.uk.linux.org/pub/linux/alan/2.1/patch-2.1.132-ac2.bz2

Ah. Thanks.

> see 'softirq.h' files in it.
> For the idea WHY your code is wrong, see Alpha's definitions
> for atomic_inc(), and friends. You must not go setting,
> or (heaven forbid), blindly ++:ing fields in there!

I'm still confused. Is there any documentation/book/webpage/gopher hole/etc
that I can read for this? In particular, what exactly is non-atomic about
++/--?

-- DN (Confused, but learning, ala Farenheit 451 ;-)

-- 
-----BEGIN GEEK CODE BLOCK-----
Version: 3.1
GCS d- s--:+ a-->? C++(---) UL++++ US+++$ P- L+++ !E W-- N+++ !w M++$ V?>+++
PS--- PE++ t--(*) 5+ X+ R+(*) tv-- b+ DI+++ D--- G? e>++++ h* r++>+++ z+>++++
------END GEEK CODE BLOCK------

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/