Re: [patch] Re: 2.2.0-pre2 fat_read_super: Bad fsinfo_offset

Torbjorn Lindgren (tl@fairplay.no)
Sat, 2 Jan 1999 15:53:48 +0100 (CET)

This message is in MIME format. The first part should be readable text,
while the remaining parts are likely unreadable without MIME-aware tools.
Send mail to mime@docserver.cac.washington.edu for more info.

---658378529-850945940-915288828=:1729
Content-Type: TEXT/PLAIN; charset=US-ASCII

On Fri, 1 Jan 1999, christophe leroy wrote:
> My first patch was imcomplete and was apparently corrupting
> vfat fs.
> This one wont corrupt anything, and people should be able
> to mount correctly vfat32 fs

It doesn't corrupt anything, but it doesn't mount fat32 filesystems
either... (Scandisk can't find anything wrong with the filesystem)

Going back in the linux-kernel archive it looks like this is some kind of
attempt to avoid an oops when mounting a specific floppy, that have an
*almost* valid filesystem on it?!

Even if it didn't HAVE negative side-effect it would have been pretty
close to what should go in this close to 2.2.0, but the first version
trashed filesystems and the second just made them unavailable from
Linux(mine and at least one other report to linux-kernel in less than one
day!)...

Please Linus, just yank out that code until after 2.2.0! Preferably until
after it's debugged, if ever, but at least until after 2.2.0 is out of the
door.

Patch to revert remove the code from 2.2.0pre3 is attached.

---658378529-850945940-915288828=:1729
Content-Type: TEXT/PLAIN; charset=US-ASCII; name=diff
Content-Transfer-Encoding: BASE64
Content-ID: <Pine.LNX.4.04.9901021553480.1729@dahlin.fairplay.no>
Content-Description: Remove bogus FAT32 check
Content-Disposition: attachment; filename=diff

LS0tIGxpbnV4L2ZzL2ZhdC9pbm9kZS5jLm9yaWcJRnJpIEphbiAgMSAyMTox
OTo0NSAxOTk5DQorKysgbGludXgvZnMvZmF0L2lub2RlLmMJU2F0IEphbiAg
MiAxNTo0NDo0MiAxOTk5DQpAQCAtMzY0LDExICszNjQsNiBAQA0KIAkJTVNE
T1NfU0Ioc2IpLT5yb290X2NsdXN0ZXIgPSBDRl9MRV9MKGItPnJvb3RfY2x1
c3Rlcik7DQogCQlNU0RPU19TQihzYiktPmZzaW5mb19vZmZzZXQgPQ0KIAkJ
CUNGX0xFX1coYi0+aW5mb19zZWN0b3IpICogbG9naWNhbF9zZWN0b3Jfc2l6
ZSArIDB4MWUwOw0KLQkJaWYgKE1TRE9TX1NCKHNiKS0+ZnNpbmZvX29mZnNl
dCArIHNpemVvZihNU0RPU19TQihzYiktPmZzaW5mb19vZmZzZXQpID49IHNp
emVvZihzdHJ1Y3QgZmF0X2Jvb3Rfc2VjdG9yKSkgew0KLQkJCXByaW50aygi
ZmF0X3JlYWRfc3VwZXI6IEJhZCBmc2luZm9fb2Zmc2V0XG4iKTsNCi0JCQlm
YXRfYnJlbHNlKHNiLCBiaCk7DQotCQkJZ290byBvdXRfaW52YWxpZDsNCi0J
CX0NCiAJCWZzaW5mbyA9IChzdHJ1Y3QgZmF0X2Jvb3RfZnNpbmZvICopDQog
CQkJJmJoLT5iX2RhdGFbTVNET1NfU0Ioc2IpLT5mc2luZm9fb2Zmc2V0XTsN
CiAJCWlmIChDRl9MRV9MKGZzaW5mby0+c2lnbmF0dXJlKSAhPSAweDYxNDE3
MjcyKSB7DQo=
---658378529-850945940-915288828=:1729--

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/