Re: [patch] ad1848.c and opl3sa2.c

Scott Murray (scottm@interlog.com)
Tue, 5 Jan 1999 02:52:47 -0500 (EST)


On Sun, 3 Jan 1999, Ben Hutchings wrote:

> On Sat, 2 Jan 1999, Andrew Kieschnick wrote:
>
> >
> > These patches are against 2.2.0-pre3.
> >
> > ad1848.c: add back 2 lines that disappeared sometime after 2.1.131 so
> > CS4231 gets detected as CS4231 and not CS4248
> > opl3sa2.c: report unknown chipset, but go ahead and act like its an
> > opl3sax. (Works for whatever flavor opl3sa I've got)
> <snip>
>
> My OPL3SAX appears to have version number 7. I guess that the `version
> numbers' 1, 2 and 4 may actually be flag values, and that it might be
> reasonable to test them in the order 4, 2, 1 in order to identify the
> chip. Does that sound plausible?

That sounds in line with the various emails I've received in the last few
days. Much to my dismay, I totally missed this now obvious heuristic.
Oh well, at least I can remove the force option now. Here's a patch
against pre4-ac2 (I think it will also apply against ac1) that should fix
the chipset detection once and for all.

Scott

-- 
=============================================================================
Scott Murray                                       email: scottm@interlog.com
http://www.interlog.com/~scottm                     ICQ#: 10602428
-----------------------------------------------------------------------------
     "Good, bad ... I'm the guy with the gun." - Ash, "Army of Darkness"

--
begin 644 opl3sa2_pre4ac2.patch.gz
M'XL("%R^D38``V]P;#-S83)?<')E-&%C,BYP871C:`"M6GM3XT82_]OZ%!TG
M&^S8,K:$,8^0+.&1Y;+`'H9+4KDMEY#&>`Y+<C02X-KDNU]WSTB67\#NG:LP
M:#33CU\_IJ<'V[9A+*/LR79:3JMM3Q*Q97N^LQDD\D$D:E/%611LQI.QJSRG
MY5>N,P'_\"*`+K0[>^[N7K<+G=W=7:O1:&A*+<]_Y>HM9Z_KZ-5OWX*]U>Q!
M@[[>OK4`OH-#&,>/,!8/8@R:(`SC!'[W0F_DP>6']Z[=/W3`BP+H'[K@>TF@
M6KRR?_BD'T&-XFP<P&.<W#?!4Y".Q!2\1,!_,I7"@Y=(+TH5Q$-Z0V28@&4C
MD:-X,DWDW2@E"7>@[\=I"N=9DGA3^%[14_A61JE(QO%=RX_#'ZS&TJHF:_>:
MM<251+_$Q3+RQN,IW'I*!!!'+-I1?\MQG1R'FHS`5S32\NMP.X5W7A1ET/<>
MXK$G(Q$Q+4(FQL6):@%<()8R\N-D$B=>*A3X<2`V92`0E6$2AS!1JN4C2&,5
M%Q39+LYN<QL:^+V;6V9.G]+G:.1%=RAS(%+AIQ)%)R:0(D$!88RPHP'OY(.,
M[II,:-W'"P(D@Y-]`?&$*:&88P]ME@@5)^GSRX?R"9?+V$_'.#_-D@A-/<X$
MXE`[%CZX;3;,3IU-MDZ;O@PG8P1[09N22R%88[9.*D,!4?S(]-9]:H\R'>%T
M+[I7A,E/(H)W6>J/$`[%KDVD1B)+I$JE7V\^2RT18?R`6B)7R*)(^$(I+YG.
M@8;J4K1UM1O6<R?;M(`-VW6;'0<:W6WZ1:;].A!#]!XX/CD]O'E_/3@_.R)6
MW?;RJ^NS\Y^N3@#?6(W\W=&[LP_]D^O!S<4O%Y>_7H#=L1H6;.IPNKB\/ME;
MFF+`##V$@=5'4EXV3K6],"YYK?&NRXO3LY\'%/@8]P-#"IT:@RX:RKL6_H6P
MAMZ]`$P:R30E9$L$V&0Z.'$JV4[)-/,(*4P<!/;U2"C!^2&CV+O%Z"''"SV%
M)O/N,+30`Q]'7LJR4HHQ_J6TL2CB/`HMG$>)I:7AMI]!"!;?&?T`UKYS`9QU
M[WX#V&+C;O?8N+VV2:A?RR$N6``1K8?V@5]1HPU4<PJ4M1&.'[74JY;DN%LV
M+NR+%-!_)PI_RR'J'4[DF$(O0D,01/<BB3!]$S5$!+V:7A5+#M;0WD?>8JR$
M!:L7S:/(LZ-`#HTVER-X%.-Q$[<.THHSO>_Y%*;X$WD8JA0"AK0_\I*<]H!>
M_M'9_KBOX\/!R-C"`'&V,`,2B!9+,DGB6S$PNUI-I4GFIY2R,#6I@8R&,7PW
M>ASX[)08=)\LNY)%2MY%B$R9G?ICYR.J\VE1H29IT6;0*O@QWC_O'CRG\^P<
ME^<X:^:4>;G/TOF-YVR]8D[W%;RV7R%S#^?`W_L6+.!FO!,Q:]-+'DN]N_T\
MGW4[S4X;BXCN5J>)=8FV6`43$%0P.(\QCR<AA4SN2NET(J#&:#)K3,%8.M11
M/*H!:,T[[X'W+TS:P1C_>HQA$BLE;_$!TV^22-H1BBRRIU=UZG"C<.<HXL%L
MVXMA0>F"\W4P)Y(FXA@BMYG$?.CA_AED8]'$9TQ!7+4@L4(&SD=E&J0R`2V'
MM2)RED('-T"K00`UB./[.,8M;19I.=R8++$20U%<N)6Z6I)1()Z@_=0^;$(H
ME8_QYD4BSA13VL1O$QZ#1'A!K0@'^P<9#ZBPP7QI/""/_?.S_M%LM#9G^>_J
M\*V1IKZ/<W+)OCT@&7K[1@TXYWTD?QMEX2U*C3!Y$XS9B<2ZIU".A41P"E*+
M'HW85#Z1/,N)Q\P@22KH?_AFXVF#GR8)VOB^]LO)U<7@[.+T$JJG5`+GU>H3
MU'X_/^UU=NO_CJJLR=_XHU-=A?($250"BW:8@<INV5%7F@\JSRGA8OJI:,)D
M9?KU_[*SIJ5#^45;S^)]WMJS\>?L3;.6+&X;I3[3YK1H9M`B$9OE']F(:RWN
MZM?&Y*XV^4LV=XW-N\;F:)"_Z<M8O;`.13N5'0FHB?#E4):R@A%<807IC]8Y
M2)VE><8;'/8&P[#BHV7`V=,/:U5V]LV$6S3N?0Z[7NR^M-A=O=C4>/GJ,GXG
M5U=0?:/VX":ZQ\HV*A!X$R!ZQF',S@&#P>G9^Y/!8&%X'3S[:Z6=%1)STE;(
M4K;^HA^VF*WQ*]NK5/8L6,P8S`S2QF+0S\&'UV!?DJ<R6YVC_Q+X<]C/0__9
MR*\&WHSF6NZODVL>YIE6!E_\1E2/XX*SB0,?2[5L.-S3F"Y#RH@R)`OP:2U?
M"$_'A&?'A*<]"W!G0S^6$5S!QWT5G\4T4.+COH[/;Z_BL[C%E/@\K>`SYQ!+
M_G`1Y^T6+PMD3`>;-(G'8V[%(%/#(L]@9T.LO#>P8O)\K(BHAX%5MW^/D4'E
MB4E+36`V(%.(LR*US=*63F-E&S06??459FQP\-)WGF?U9OZL7Y89_[B*,8*B
M!XW+5_-@68>2T:G(_,MZZ-&<'@7@XK9\`&^>.`3+,V<A6!Z=[9F0)Z]*;APZ
MJZD8#S\*=W#3#UG>$5?&:@F2DO\T]$:&/_-EYE?+=0I\TL76,U.XV@*6]&<1
M">I18=$[P>-U.IT=VC"E,H`%*3ZR-:%JW."-7VW2D4`C8'H_'7V<V][I48=Q
MV^F:TQQ[8?(G(W>`9_%]/12$WHHA9S9DTY#NLQ2S+#B_/+Y!BWPXO#JOR1A%
MDFSSTO#@^*1_I-^1,>1FS#T^JK,*+^8CB&YF8DVD=!2UG]Q>NT[D2(]>N]?<
M13VV\E-IF3-)NIZW>4O<S_M]J+&_UD$)=-D`CL\/J?J*Z&A2HQ99$USFB@8N
M\V#5<R;V$I/\]2DCM!02N0_4G)R\74A*ZZ_./ER?75[4JN=\X.'&V%*SEQO+
MIL>+,*$G'QYW=K9V6"U]VJJWRA@<WER_N[RJ55]NQ6J%&6BWPPZSW6WNY(=)
M=&)4YX"L#G_]Q>Y3/)#CE!^<V5-(G0&SKI[7^BNW7W(//;M)U)M$J,EZ,\60
MNAFW&,0B;7%2:*S,4.5\\KD482G)S$63?7)V\:_#]_L<^@S3EL.MINU>SSAD
MQ1_>M69AA'_MSP:=8M"AT7S7%]R<UP45'6^?/=W^6)QM=1A^I7&E?1.9S)^:
M=*3NS^JW57.6TYY5=%HWN2_(GJ7KRCV=B@A3(F5..6"TU5#OER>8'&,FX"/2
M?]W%2]'97''QLO7BQ<NZU5ON7KLSNWAQVB[Y.?W*VUP`@9@,4NI$4R+>Z&>3
M29RDJRY@3.]$1^:3N;7X$'W0T;F1M_CZES<7QT5S\YOYT7Z?6,HA_`'5;U8M
MJ")NU6D5/NZ3+T26K<&D1+QQE"<4##62S\O2F%MT37"XI^/6-]8UCZD!:TX-
M>,[=R,732>ML\U(GZ%K7;8,-IYA?<-^4P3*]GP[[)X"S<FHLV`*UJW]2)[[7
MA%U,K9A;.YSM.]TE8C1S]QE*E*<I/;-N2ZOY[7K_.H[]+!11R@TKXR>Y*9>=
M;&O5[=YGD$!/<TI7?`[[F>E(V__;A]RTG,V;L"*;6_:Q\`6U!/2-C]5`V3*Z
M)^F:`:2BKR8.Z2XG\0)AAU["-:M(0@6D**I)MP&"[B/I<H`:"R))I<AO#F62
MFRL1=&I),0H!ZT*Z>F/%=WM-IPN-W5Y^U6)1L3R-,SS;2&3LXZX;IW`G],V"
M[O51"AS'7M#$;]VQX3R(6ZG0EY8644A`354J0IQT!T-)+<*\;MA\\))-'-X,
MZ7+HCNZ_"K:"LZIEFU<OU_I46&'H\>H1M44]".1P*!(4QK*+[(SU`YS1&4!$
M/BY#$!$Z%</02Y`[MYXX2,F=!)V82:=<=,M.Z7)%>5,%U>+:>%5)_#V7LKK;
M\T-UIA=M':04=X`"Y%Q*7`P6925T%8'I*C0W`KIEQ)>@Z4@J+1GF,\OVHBE0
M0S\)V==GNIM;6;YKHLR7"Q@/C4F*^J1)5`(XRZ^Z<*?U;K5M^3XJFU"9BZZ&
M53F5E?*I10>J0W2_D*YJT555/,Z8O>2>K][R^+),MY5)5;J!4"`D7?<B05U*
M6G3NG&&#>^O,N[S$+&]JI=$#2;8`71W,124Z!?.J6G9^GP@W2D9W9OP`TS(A
MH.:$P<-!.H.:I&)Q#`YFI9NOQ%/@FA4N7UJG)++Q?,W!L@,J%BA<<"&Y>>&&
MW.SC\#<WZ")]%"+*[_;S/0K-'UOV3!+4OCBPJDRF;!]VTJCX5P(VBL&1.O)!
M6>>%OCYNAJ!D*`EC<WLM%:K_X.'0+05HU>Q9Y+A8C*>$J>22A_<$%RV`26$J
MA>&CZ/R#J05/ZDA'E6V3<V!0\DMDG3_(\K@*TV!([IXF4[X/I?W1I@V2N`YE
M@N5?K1`(Q)\(!!A]\MM8=&NLKQ!/9(!!2IQI,36^,#!NY5CB(8V]QIMU;4Q,
MM*Q&D6->>5Q>3C56HS`R?'&JL1KE7`-?F&JL1BG5P)=F&I*EE&K@2S.-U2BE
M&OCL3#/;AX*80\KL"TLP&!-J%A$E"?,_,_P/)E;^7M&)71%YD]E+>Q/MG",Q
MG@PSC!`18C`0+@QN(%)\5+Q5=ERN$CJ=75,G:`?'_4X;"<\S!WP@-I4V/E!Y
M%DXR_>#B`Y;8!STZ8ART^:!QX,Z3,31V:/NWK_7M-_T_`,:@C\4$RH^I(-6I
M+>9=&5VM:+!QEB)(*08(FZG5>!V19VD8K-!U+R,Z.-._&S2I*)Z%`3H)X\U7
@T&,1JA*0.DE:^44TNA920\>ZQ5,4&?J_6^5$4.LE````
`
end

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/