Re: [PATCH] MM fix & improvement

Zlatko Calusic (Zlatko.Calusic@CARNet.hr)
09 Jan 1999 09:05:16 +0100


Linus Torvalds <torvalds@transmeta.com> writes:

> On 9 Jan 1999, Zlatko Calusic wrote:
> >
> > OK, here it goes. Patch is unbelievably small, and improvement is
> > BIG.
>
> Looks good. Especially the fact that once again performance got a lot
> better by _removing_ some silly heuristics that didn't actually work.
>

Yes, that's the thing that I like with changes, too.
Let's remove anything that can be removed. :)

I'm just looking into buffer reference issue you mentioned.

I already noticed that part of code that was dealing with buffer
reference in shrink_mmap() disappeared some time ago. But I didn't
have a slightest clue that fs/buffer.c survived such mass deletia, as
one I just found in there. :)

I'll implement simple buffer->page reference functionality, benchmark
it and let you know what I've found.

At this point, I think it will improve things, but let's wait and see.

Regards,

-- 
Zlatko

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/