Re: [patch] getname buffer moved to slab cache
Andi Kleen (ak@muc.de)
09 Jan 1999 20:24:04 +0100
In article <Pine.LNX.3.96.990108131523.197B-100000@laser.bogus>,
andrea@e-mind.com (Andrea Arcangeli) writes:
> +void __init namei_init(void)
> +{
> + getname_cache = kmem_cache_create("getname_cache",
> + PAGE_SIZE,
^^^^^^^^^
> + 0,
> + SLAB_HWCACHE_ALIGN,
> + NULL, NULL);
> + if (!getname_cache)
> + panic("cannot create getname cache");
> }
I don't think this patch is a good idea. Slab tries to allocate slabs with
multiple objects, and allocating multi-page objects is notoriously unreliable.
Slab is really only suitable for smaller objects.
-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/