2.0.3[67] networking oops

Tony Gale (gale@syntax.dera.gov.uk)
Wed, 13 Jan 1999 09:55:34 -0000 (GMT)

There's a bug in 2.0.xx related to threading and networking. Oops is
below (Alan: I'll send you some code to produce an oops separately).
2.2.0preX seems to be ok. A cursory look suggests that the following
patches to net/socket.c need to be backported:

Alan Cox : Added thread locking to sys_* calls
for sockets. May have errors at the
moment.
Kevin Buhr : Fixed the dumb errors in the above.
Andi Kleen : Some small cleanups, optimizations,
and fixed a copy_from_user() bug.

Cheers

-tony

>>EIP: 135dc5 <sock_select+19/30>
Trace: 135dc5 <sock_select+19/30>
Trace: 12cc76 <select_check+32/84>
Trace: 12ce25 <do_select+15d/280>
Trace: 12d166 <sys_select+18e/260>
Trace: 1442e5 <tcp_sendmsg+8d/d8>
Trace: 144326 <tcp_sendmsg+ce/d8>
Trace: 14f41d <inet_sendmsg+95/ac>
Trace: 135d6e <sock_write+9e/b4>
Trace: 10a8bd <system_call+55/7c>
Trace: 809002b

Code: 135dc5 <sock_select+19/30>
Code: 135dc5 <sock_select+19/30> 8b 40 24 movl
0x24(%eax),%eax
Code: 135dc8 <sock_select+1c/30> 85 c0 testl
%eax,%eax
Code: 135dca <sock_select+1e/30> 74 0c je 135dd8
<sock_select+2c/30>
Code: 135dcc <sock_select+20/30> 51 pushl %ecx
Code: 135dcd <sock_select+21/30> 53 pushl %ebx
Code: 135dce <sock_select+22/30> 52 pushl %edx
Code: 135dd5 <sock_select+29/30> ff d0 call *%eax
Code: 135dd7 <sock_select+2b/30> 83 c4 0c addl
$0xc,%esp
Code: 135dda <sock_select+2e/30> 5b popl %ebx
Code: 135ddb <sock_select+2f/30> c3 ret
Code: 135ddc <sock_close> 89 f6 movl %esi,%esi
Code: 135dde <sock_close+2/2c> 31 00 xorl %eax,(%eax)
Code: 135de6 <sock_close+a/2c> 90 nop
Code: 135de7 <sock_close+b/2c> 90 nop
Code: 135de8 <sock_close+c/2c> 90 nop
>>EIP: 135dc5 <sock_select+19/30>
Trace: 135dc5 <sock_select+19/30>
Trace: 12cc76 <select_check+32/84>
Trace: 12ce25 <do_select+15d/280>
Trace: 12d166 <sys_select+18e/260>
Trace: 13845c <sk_alloc+10/30>
Trace: 135a32 <get_fd+16/7c>
Trace: 111d09 <schedule+15/28c>
Trace: 117767 <do_bottom_half+3b/60>
Trace: 10a8bd <system_call+55/7c>

---
E-Mail: Tony Gale <gale@syntax.dera.gov.uk>
The majority of husbands remind me of an orangutang trying to play the violin.
		-- Honor'e DeBalzac


The views expressed above are entirely those of the writer
and do not represent the views, policy or understanding of
any other person or official body.


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/