Re: Linux 2.2.0pre7ac2

Trond Myklebust (trond.myklebust@fys.uio.no)
14 Jan 1999 22:34:21 +0100


> > > o de4x5 should compile ok now
> > [...]
> >
> > Yes, it compiles but the changes in asm/string.h make it oops
> > on first use. (using both gcc and egcs as per RH52 std.)
>

Indeed. The fix tries to save the early-clobbered value of 'edi' in
another early-clobbered register ('edx') and is clearly wrong.

I suggest making 'strstr' an external function rather than an
inline. As it stands, it leaves no free general purpose registers for
the compiler to work with, so the optimization gain from inlining will
in any case be extremely limited.

Cheers,
Trond

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/