Re: [PATCH] VFAT fixes.

Linus Torvalds (torvalds@transmeta.com)
Thu, 14 Jan 1999 22:20:50 -0800 (PST)

On Thu, 14 Jan 1999, Alexander Viro wrote:
>
> b) new function in dcache.h - d_try_drop() that tries to get rid of
> children and unhashes dentry if we are sole owners. Needed to fix the race
> in emptiness checking in vfat_rename() (and other foo_rename()'s, but
> that's another story)

Your d_try_drop() does the wrong thing if the dentry is a directory,
didn't have any children but _did_ have a count > 1 - it would drop it
because it didn't check the count for the path where there were no
children.

Basically, I think you _tried_ to do what "d_invalidate()" already does
(check the latest kernels for some fixes to d_invalidate()).

Linus

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/