Patch needed to Rules.make?

baccala@freesoft.org
Mon, 18 Jan 1999 05:36:35 -0500 (EST)

--17433089-1804289383-916655802=:12612
Content-Type: TEXT/plain; CHARSET=US-ASCII

Hi -

I've been running with the attached patch to Rules.make.

Question: is it correct?

The old code seems both redundant (if $*.stamp doesn't exist then the
second part of the test will fail anyway, so the first part isn't
needed), and just plain wrong (if the $*.ver file doesn't exist then we
want to run GENKSYMS no matter when the $*.stamp file was made).

Comments?

-- 
					-bwb


					Brent Baccala
					baccala@freesoft.org


-------------------------------------------------------------------------
To receive periodic news about what's happening at freesoft.org, send
email to "announce@freesoft.org", with "SUBSCRIBE" as the message, i.e:
		echo SUBSCRIBE | mail announce@freesoft.org
-------------------------------------------------------------------------


--17433089-1804289383-916655802=:12612
Content-Type: TEXT/plain; CHARSET=US-ASCII
Content-Description: patch


*** Rules.make  1999/01/02 16:44:01     1.25
--- Rules.make  1999/01/18 10:28:18
***************
*** 204,210 ****
  endif
  
  $(MODINCL)/%.ver: %.c
!       @if [ ! -r $(MODINCL)/$*.stamp -o $(MODINCL)/$*.stamp -ot $< ]; then \
                echo '$(CC) $(CFLAGS) -E -D__GENKSYMS__ $<'; \
                echo '| $(GENKSYMS) $(genksyms_smp_prefix) -k $(VERSION).$(PATCHLEVEL).$(SUBLEVEL) > $@.tmp'; \
                $(CC) $(CFLAGS) -E -D__GENKSYMS__ $< \
--- 204,210 ----
  endif
  
  $(MODINCL)/%.ver: %.c
!       @if [ ! -r $(MODINCL)/$*.ver -o $(MODINCL)/$*.stamp -ot $< ]; then \
                echo '$(CC) $(CFLAGS) -E -D__GENKSYMS__ $<'; \
                echo '| $(GENKSYMS) $(genksyms_smp_prefix) -k $(VERSION).$(PATCHLEVEL).$(SUBLEVEL) > $@.tmp'; \
                $(CC) $(CFLAGS) -E -D__GENKSYMS__ $< \


--17433089-1804289383-916655802=:12612--


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/