Re: linux-2.2.1-ac3 and egcs-19990131

Jeffrey A Law (law@hurl.cygnus.com)
Tue, 02 Feb 1999 20:03:36 -0700


In message <199902030238.XAA18554@sleipnir.valparaiso.cl>you write:
> This combination (and probably others) won't work, since the inlining
> changed. The following snippet out of net/unix/af_unix.c (heavily hacked to
> reduce its size) will inline skb_put() under egcs-1999012, but not under
> 19990131. I assume the kernel source isn't quite right, as it assumes that
> functions declared "extern inline" will always be inlined with -O2
> -fomit-frame-pointer, and no real function is being provided anywhere for
> linking to. OTOH, it declares functions inline so they _will_ be inlined
> for performance.
>
> I've been away for some time, and can't take up the lists just now. So if
> this has already been discussed to death, sorry.
It's an issue rth and davem are on the hook for dealing with.

It's not strictly correct for any function to assume that specifying "inline"
will force the function to be inlined. That may or may not change depending
on what rth & davem decide to do.

jeff

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/