Re: knfsd error message

G. Allen Morris III (gam3@harpo.ixlabs.com)
Thu, 18 Feb 1999 09:57:21 -0800


This is a multipart MIME message.

--==_Exmh_6800339960
Content-Type: text/plain; charset=us-ascii

What kind of computer is the client? If it is a linux box I would
be confused. This message is not harmful, nfs is just tring to
create a files/directory that all ready exists.

Here is a BETA patch that may get rid of most of these messages.

Allen

>>>Greg Whalin said:
> During large cvs checkouts on a NFS mounted disk, the knfs server reports
> tons of the following message ...
>
> nfsd_create: dentry filename not negative!
>
> This repeats for most of the files checked out. Any ideas?
>
> Thanks,
> Greg
>

---------------------------------
G. Allen Morris III

--==_Exmh_6800339960
Content-Type: text/plain ; name="nfs_create.diff"; charset=us-ascii
Content-Description: nfs_create.diff
Content-Disposition: attachment; filename="nfs_create.diff"

diff -u -X exclude linux-2.2.1/fs/nfsd/vfs.c linux/fs/nfsd/vfs.c
--- linux-2.2.1/fs/nfsd/vfs.c Tue Feb 2 09:53:31 1999
+++ linux/fs/nfsd/vfs.c Wed Feb 17 11:24:55 1999
@@ -658,10 +658,6 @@
if (IS_ERR(dchild))
goto out_nfserr;
fh_compose(resfhp, fhp->fh_export, dchild);
- /* Lock the parent and check for errors ... */
- err = fh_lock_parent(fhp, dchild);
- if (err)
- goto out;
} else {
dchild = resfhp->fh_dentry;
if (!fhp->fh_locked)
@@ -670,6 +666,15 @@
dentry->d_parent->d_name.name,
dentry->d_name.name);
}
+ err = nfserr_exist;
+ if (dchild->d_inode)
+ goto out;
+ if (!fhp->fh_locked) {
+ /* Lock the parent and check for errors ... */
+ err = fh_lock_parent(fhp, dchild);
+ if (err)
+ goto out;
+ }
/*
* Make sure the child dentry is still negative ...
*/

--==_Exmh_6800339960--

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/