Re: 2.2.1-ac6 CDROM bug (not in 2.2.1-vanilla)

Alan Cox (alan@lxorguk.ukuu.org.uk)
Sun, 21 Feb 1999 18:02:27 +0000 (GMT)

> Actually its not that simple. Plain 2.2.1 doesn't have the timer reuse
> trap code in it. 2.2.1 potentially added the timer twice.
>
> Can you boot 2.2.1 vanilla with just Ingo's timer bug check patch in it ?

Better yet try this instead. scsi_error wasnt calling init_timer(). Thats
a non fatal offence in 2.2 but trips the bug trap up. It is a real bug
though, some time in the future init_timer() might have done far more.

Alan

--- scsi_error.c~ Fri Feb 19 00:00:42 1999
+++ scsi_error.c Sun Feb 21 17:03:08 1999
@@ -563,6 +563,7 @@
struct semaphore sem = MUTEX_LOCKED;
struct timer_list timer;

+ init_timer(&timer);
timer.data = (unsigned long) &sem;
timer.expires = jiffies + timeout;
timer.function = (void (*)(unsigned long))scsi_sleep_done;

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/