lp on fire! KERN_ERR to KERN_INFO

B. James Phillippe (bryan@terran.org)
Sun, 7 Mar 1999 22:40:07 -0800 (PST)


Hello,

"lp%d on fire!\n" is one of my favorite Linux printk's. :) However, seeing
as it indicates a not-uncommon problem with a non-critical external
peripheral (the printer) and poses no significant concern, I think the
priority should be changed from KERN_ERR to KERN_INFO.

--- lp.c-old Sun Mar 7 22:32:25 1999
+++ lp.c Sun Mar 7 22:32:58 1999
@@ -437,7 +437,7 @@
} else if (!(status & LP_PERRORP)) {
if (last != LP_PERRORP) {
last = LP_PERRORP;
- printk(KERN_ERR "lp%d on fire!\n", minor);
+ printk(KERN_INFO "lp%d on fire!\n", minor);
}
}
else last = 0;

Totally trivial, but... better to have the message only appear in your logs
than in all your terminals and wake your monitor from powersave (assuming
typical sane syslog configuration). :)

cheers,
-bp

--
B. James Phillippe		. bryan@terran.org
Software Engineer, WGT Inc.	. http://www.terran.org/~bryan

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/