KDKBDREP?

J. S. Connell (ankh@canuck.gen.nz)
Fri, 19 Mar 1999 13:13:41 -0500 (EST)

While figuring out why kbdrate caused a kernel panic on SPARC, I did
some spelunking through the various keyboard-related things inside the
kernel. It appears that there's a lovely common API for setting the
keyboard repeat rate, KDKBDREP, but that the only platform that implements
it is m68k.

Is there any particular reason why this is the case?

As far as the kernel panic goes, that's kbdrate's fault for trying to frob
/dev/port. The below patch fixes it, but is it the Right Thing?

--Jeff

--- linux.orig/drivers/char/mem.c Fri Mar 19 13:03:45 1999
+++ linux/drivers/char/mem.c Fri Mar 19 13:12:16 1999
@@ -530,7 +530,7 @@
case 3:
filp->f_op = &null_fops;
break;
-#if !defined(CONFIG_PPC) && !defined(__mc68000__)
+#if !defined(CONFIG_PPC) && !defined(__mc68000__) && !defined(__sparc__)
case 4:
filp->f_op = &port_fops;
break;

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/