Re: [RFC] set_blocksize() oddity.

Chuck Lever (cel@monkey.org)
Sat, 10 Apr 1999 13:42:23 -0400 (EDT)

On Sat, 10 Apr 1999, Andrea Arcangeli wrote:
> > It looks like we actually need to replace
> >remove_from_hash_queue(bh);
> > with
> >remove_from_queues(bh);
> >bh->b_dev = B_FREE;
> >insert_into_queues(bh);
>
> I just said exactly that some days ago in my _first_ email with the
> subject `buffer.c glitches'. Both invalidate_buffers() and set_blocksize()
> should put all invalidated buffers in the freelist.

i agree - these two routines are another source of orphaned buffers.
however, i think using the new bforget() code might be better:

bh->b_count = 0;
remove_from_queues(bh);
put_last_free(bh);

- Chuck Lever

--
corporate:	<chuckl@netscape.com>
personal:	<chucklever@netscape.net> or <cel@monkey.org>


The Linux Scalability project:
	http://www.citi.umich.edu/projects/citi-netscape/




-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/