Re: ia64: Patch 2.3.4pre1 looks fishy

Evan Van Dyke (e-van@nwu.edu)
Sat, 29 May 1999 22:26:54 +0000


Horst von Brand wrote:
>
> I have no idea what is going on here, but this doesn't look right:
>
> diff -u --recursive --new-file v2.3.3/linux/fs/open.c linux/fs/open.c
> --- v2.3.3/linux/fs/open.c Fri Apr 16 14:21:39 1999
> +++ linux/fs/open.c Mon May 24 22:47:43 1999
> @@ -171,7 +171,7 @@
> return error;
> }
>
> -#ifndef __alpha__
> +#if !(defined(__alpha__) || defined(__ia64__))
>
> /*
> * sys_utime() can be implemented in user-level using sys_utimes().
>
> The last #if is supposed to match if __alpha__ is not defined, but __ia64__
> is. This is absurd, AFAIU they can't ever be both defined.

Umm, not the parenthesis. It's true if __alpha__ is not defined
AND __ia64__ is not defined.

--Evan

--
Evan Van Dyke                               E-mail: evandy@netcom.com
Page: 15442232@pager.mirabilis.com          ICQ#: 15442232
DNRC's Minister of Lost Internet Packets.   O-
Amateur Radio Call Sign:  KB8PVE            Elder ResCon at Northwestern

GCS/S d+(-) s:+ a--- C++++ UH+I++L++++S++V++++ P+ L+++>++++ E W++ N++ w-- O- M-- !V PS+ PE+ Y+ PGP t+ 5+++ X+ R+ tv+ b+++ DI++++ D+ g e h !r y-

"Quoth the Raven... 'Nevermore!'" --Edgar Allen Poe "I'll bet that all you can do is watch the ball bounce around the screen. --Dilbert to Management

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/