On 13 Jun 1999, Andi Kleen wrote:
> Walter.Hofmann@physik.stud.uni-erlangen.de (Walter Hofmann) writes:
>
> > I have updated my apm patch. It switches the processor to real mode before
> > it attempts to turn off the computer. This should solve the problem seen
> > by a number or people.
>
> Wouldn't it be better to share the real-mode switching code with the reboot
> code in machine_restart ? Perhaps by merging both into a generic
> "void execute_in_realmode(void (*)(void *))" function. Having such stub code
> twice is redundant and wastes precious kernel memory. Also it is harder
> to maintain, because bug fixes have to be duplicated then.
Agreed. It was my intention to change as little existing code as possible
when I made this patch. I'll try to create a unified function as well as
merge my patch with Stephens recent APM update when I have time.
Walter
-----BEGIN PGP SIGNATURE-----
Version: PGPfreeware 5.0i for non-commercial use
Charset: noconv
iQCVAwUBN2Ozu/zeA3/eVHOFAQEZuQP/a2RKqE2au1eex/SCW9g8p6A1JHy2bJq9
yGfGEqRaNSXdDehvbxz7tAK3+s8ktAvvx+BMw66tBMYp2i3BPeAkc4FV2dcEjtZz
R5GgaKOA5gVBysuC6dxH5RA0cJxyuEecOPR4mEG1nq+VyrdpTayj7/fUgcO/4X+M
g/0DwaJpd58=
=M+nX
-----END PGP SIGNATURE-----
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/