Re: [PATCH] /proc/ide/hd?/geometry (un)signedness 2.2.10, 2.3.8

Matthew Wilcox (Matthew.Wilcox@genedata.com)
Mon, 5 Jul 1999 10:27:46 +0200

On Sat, Jul 03, 1999 at 11:40:08AM +0200, Matthias Andree wrote:
> Should not in ide-proc.c around line 715 the sprintf parameters %hi be
> replaced by %hu so that the kernel returns the proper "39560" cylinder
> count? Looking at ide.h, the cyl is unsigned short anyways so %hi is
> actually really wrong (Just wondering why gcc doesn't warn although
> -Wall is set).

-Wall doesn't warn about this sort of thing. -W turns on this set of
warnings, which I find rather useful. Would a patch which cleaned up
the header files to make turning on -W less painful be accepted?

-- 
Matthew Wilcox <willy@bofh.ai>
"Windows and MacOS are products, contrived by engineers in the service of
specific companies. Unix, by contrast, is not so much a product as it is a
painstakingly compiled oral history of the hacker subculture." - N Stephenson


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/