Re: mount options for root

Matthias Riese (mri@megatel.de)
Mon, 12 Jul 1999 19:07:58 +0200


"Stephen C. Tweedie" wrote:
>
> Hi,
>
> On Fri, 09 Jul 1999 15:09:45 +0200, Matthias Riese <mri@megatel.de>
> said:
>
> > /*
> > * Alters the mount flags of a mounted file system. Only the mount point
> > * is used as a reference - file system type and the device are ignored.
> > * FS-specific mount options can't be altered by remounting.
> > */
>
> > static int do_remount_sb(struct super_block *sb, int flags, char *data)
>
> > Seems to be a bad idea to change mount options this way?
>
> That comment appears to be obsolete. We pass the "data" field all the
> way from the mount syscall to the filesystem remount method, and
> ext2_remount certaily reparses it, so there should be no problem
> accepting fs-specific options in a remount.

Yes, it works now. I've mistaken true for false in ext2_remount.
The above comment was somewhat confusing, should be deleted IMHO.

Matthias Riese

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/