Re: Problem compiling 2.3.10

Matthias Riese (mri@megatel.de)
Mon, 12 Jul 1999 19:28:56 +0200


IMHO:
There did exist a bmap member in inode_operations.
bmap (the global function) did rely on i_op->bmap.
So this check was inserted to see if this function
would work. As bmap now does work without i_op->get_block instead,
this check should be replaced by

-if(!inode->i_op->bmap)
+if(!inode->i_op->get_block)

Matthias Riese

Chris Jones wrote:
>
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Hi
>
> > >loop.c: In function `loop_set_fd':
> > >loop.c:378: structure has no member named `bmap'
> > >make[2]: *** [loop.o] Error 1
>
> I had the same problem. A quick sift through some of the relevant
> headers leads me to believe that line 378 of loop.c should read:
>
> if (!inode->i_op->smap) {
>
> (i.e. the "bmap" should be changed to "smap").
>
> It now compiles properly, but I havent yet had a chance to test it
> properly ('cos of the fs compile problems with the 2.3 series), so it
> might go wildly wrong, but since the inode->i_op structure has no
> member "bmap", but does have a member "smap", I think the chances of
> it working are pretty high. I'm also surprised that no-one spotted
> this one before the kernel got out. I would have thought it would be
> wise to test the kernel compile with all (or at least most) of the
> options enabled before releasing it (but what do I know ;)
>
> - ---
> Chris Jones
> Black-Sun Software
> chris@black-sun.co.uk
> www.black-sun.co.uk
> Team *AMiGA*
>
> -----BEGIN PGP SIGNATURE-----
> Version: PGPfreeware 5.5.3i for non-commercial use <http://www.pgpi.com>
>
> iQA/AwUBN4nBCJhmBipjerS3EQJlMQCeN4Ly1SjoOVva/veVLy7MvlR/RdAAoMtN
> CCWTcdJ341R7/a48LoODeghb
> =Jr4E
> -----END PGP SIGNATURE-----
>
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.rutgers.edu
> Please read the FAQ at http://www.tux.org/lkml/

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/