Re: AIC 5.1.18 _broken_

Linus Torvalds (torvalds@transmeta.com)
Sun, 18 Jul 1999 19:28:56 -0700 (PDT)


On Mon, 19 Jul 1999, Alan Cox wrote:
>
> > msync-2.2.10 - update_vm_cache_conditional patch
>
> The last version I have of this from Stephen still had stuff Linus didn't like
> in paticular making assumptions about 0 and kernel space.

My preferred solution is to just add

if (get_fs() == KERNEL_DS)
return 0;

at the top of update_vm_cache(). I can't claim that it is much better than
the update_vm_cache_conditional() version, but it is at least a lot
simpler. It makes core-file and quota file writing and sendfile() non-
coherent with mmap. The core-file one is unimportant, the quota file one I
don't know if anybody cares. The sendfile() case we can document and make
a feature.

Does any quota utility mmap() the quota file? That is the big question.

Linus

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/