Re: TCP TIME-WAIT bug in Linux 2.2.5 (still there I think)

Andi Kleen (ak@muc.de)
Tue, 27 Jul 1999 17:45:00 +0200

On Tue, Jul 27, 1999 at 12:08:59AM +0200, Vijay G. Bharadwaj wrote:
> (in tcp_v4_send_ack)
>
> + rth.ack_seq = th->fin ? htonl(ntohl(th->seq)+1) : th->seq;
>
> Why assume that there was no data in the packet? Wouldn't
>
> rth.ack_seq = htonl(TCP_SKB_CB(skb)->end_seq);
>
> be better? (I might have an off-by-one error there, I can't check the
> source right now...)

It is fixed now to use snd_nxt/rcv_nxt.

>
> (and besides, why would we be generating an ACK for a data-less and
> FIN-less packet?)

Because the RFC793 example receiving procedure would, and older Linux
versions and BSD stacks would too I think. I prefer not to do any
experiments in a stable kernel.

-Andi

-- 
This is like TV. I don't like TV.


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/