RE: Minor cleanup

Jones D (djones2@glam.ac.uk)
Tue, 10 Aug 1999 14:10:59 +0100


> > where it gets confused and wrongly thinks a variable might be used
before
> > setting it). The few real bugs I found are:
> Not this one 8)
>
> > --- linux/drivers/net/8390.c.dist-2.2.11-pre7 Thu May
> 6 17:02:34 1999
> > +++ linux/drivers/net/8390.c Mon Aug 9 21:18:00 1999
> > @@ -1089,7 +1089,6 @@
> > int start_page)
> > {
> > int e8390_base = dev->base_addr;
> > - struct ei_device *ei_local = (struct ei_device *) dev->priv;
> >
> > outb_p(E8390_NODMA+E8390_PAGE0, e8390_base+E8390_CMD)
>
> This breaks 8390.c. Try building on a macintosh 68K as well
> as an x86 and you'll find the variable is most definitely used.

Could this sort of thing be hidden in an IFDEF or the likes?

d.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/