Re: [PATCH - 2.2.12, via-rhine v1.01] rx statistics bug (back , again)

Donald Becker (becker@cesdis1.gsfc.nasa.gov)
Fri, 27 Aug 1999 14:39:27 -0400 (EDT)


On Fri, 27 Aug 1999, David Rees wrote:

> > The v1.03 driver is the preferred version
> > ftp://cesdis.gsfc.nasa.gov/pub/linux/drivers/test/via-rhine.c
>
> Thanks for the reply. I've tried both version 1.02b and v1.03. v1.03
> fails to properly detect my card.

Ahhh, v1.03 uses the memory base register by default. Memory space access
doesn't work with the Rhine.
v1.03a fixes this.
ftp://cesdis.gsfc.nasa.gov/pub/linux/drivers/test/via-rhine.c

> v1.02b looks like it's working great so
> far. Here's the messages from both at boot (using 2.2.12):

> For some reason, also in 2.2.11 and above, I'm getting all these extra
> via-rhine driver version messages after the card is detected. I didn't
> get these in 2.2.10.

Hmmm, that's because the probe code in Space.c is calling the driver eight
times. It should only call the PCI drivers once, and even (especially!) in
the ISA case should give up when no more cards are found. Probing multiple
times on the ISA bus is dangerous.

Donald Becker becker@cesdis.gsfc.nasa.gov
USRA-CESDIS, Center of Excellence in Space Data and Information Sciences.
Code 930.5, Goddard Space Flight Center, Greenbelt, MD. 20771
301-286-0882 http://cesdis.gsfc.nasa.gov/people/becker/whoiam.html

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/