Re: [Link-Error] sis900.c - 2.2.12

Jim (cmhuang@sis.com.tw)
Tue, 31 Aug 1999 10:23:41 +0800

Hi,
I don't know who produce this patch.
We havn't sent any new patch until now.
This patch seems different from the original source
code I have sent to.
I think someone delete the "_" .
You could refer to ver 2.2.11.

----
Jim Huang
Silicon Integrated Systems Corp.
Tel: 886-3-5774922 Ext. 6236
E-mail: cmhuang@sis.com.tw

>
>Hi
>
>At the link stage of compiling 2.2.12 with the SIS900 driver installed
>the following error is reported...
>
>+-->
>|ld -m elf_i386 -T /root/linux/arch/i386/vmlinux.lds -e stext
>|arch/i386/kernel/head.o arch/i386/kernel/init_task.o init/main.o
>|init/version.o \
>| --start-group \
>| arch/i386/kernel/kernel.o arch/i386/mm/mm.o kernel/kernel.o
>|mm/mm.o fs/fs.o ipc/ipc.o \
>| fs/filesystems.a \
>| net/network.a \
>| drivers/block/block.a drivers/char/char.a drivers/misc/misc.a
>|drivers/net/net.a drivers/cdrom/cdrom.a drivers/sound/sound.a
>|drivers/pci/pci.a drivers/pnp/pnp.a drivers/video/video.a
>|drivers/block/paride/paride.a \
>| /root/linux/arch/i386/lib/lib.a /root/linux/lib/lib.a
>| /root/linx/arch/i386/lib/lib.a \
>| --end-group \
>| -o vmlinux
>|drivers/net/net.a(sis900.o): In function `sis900_probe1':
>|sis900.o(.text+0x3f3): undefined reference to `releaseregion'
>|make: *** [vmlinux] Error 1
>+---->
>
>I found the following offending hunk of patch:-
>@@ -574,6 +583,11 @@
>
> /* Some data structures must be quadword aligned. */
> tp = kmalloc(sizeof(*tp), GFP_KERNEL | GFP_DMA);
>+ if(tp==NULL)
>+ {
>+ releaseregion(ioaddr, pci_tbl[chip_idx].io_size);
>+ return NULL;
>+ }
> memset(tp, 0, sizeof(*tp));
> dev->priv = tp;
>
>
>
>Is it obvious fix eg.
>- releaseregion(ioaddr, pci_tbl[chip_idx].io_size);
>+ release_region(ioaddr, pci_tbl[chip_idx].io_size);
>
>HTH
>
>TTFN
>--
>Roger Gammans
>"If I have trouble installing Linux, something is wrong. Very wrong."
> -- Linus Torvalds
:.˛mkabzwmb˛mbz_^nrzh&zvy杶ii