Possible bug in the lowlatency-2.2.10-N6B.patch

DAVID BALAZIC (david.balazic@uni-mb.si)
Thu, 09 Sep 1999 16:15:30 +0100 (MET)


I find this suspicius in the Ingo Molnars lowlatency-2.2.10-N6B.patch :

--- linux/include/linux/delay.h.orig Sat Jul 31 16:02:46 1999
+++ linux/include/linux/delay.h Tue Aug 3 13:14:28 1999
@@ -25,13 +25,24 @@
#define MAX_UDELAY_MS 5
#endif

-#ifdef notdef
+/*
+ * the 'preemptive' version of udelay. In some cases we want to use
+ * this variant, it guarantees that preemption will happing within
+ * 10 usecs (despite doing busy waiting). Not all drivers can use
+ * this automatically, the driver has to be sufficiently reentrant.
+ */
+#define udelay_resched(n) (\
+ { int i; \
+ for (i = 0; i < 100; i++) { \
+ conditional_schedule(); \
+ udelay(10); \
+ } \
+ })
+

The argument n is not used anywhere in the udelay_resched macro !

--
David Balazic , student
E-mail   : 1stein@writeme.com     |     living in  sLOVEnija
home page: http://surf.to/stein
Computer: Amiga 1200 + Quantum LPS-340AT
--

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/