Re: linux/drivers/char/defkeymap.c

Martin Dalecki (dalecki@cs.net.pl)
Sun, 26 Sep 1999 01:09:27 +0200


Andries.Brouwer@cwi.nl wrote:
>
> In patch2.3.14 I find:
>
> diff -u --recursive --new-file v2.3.13/linux/drivers/char/defkeymap.c linux/dri\
> vers/char/defkeymap.c
> --- v2.3.13/linux/drivers/char/defkeymap.c Fri Feb 24 11:38:27 1995
> +++ linux/drivers/char/defkeymap.c Thu Aug 12 10:17:17 1999
> @@ -233,6 +233,7 @@
> {'A', 'A', '\305'}, {'a', 'a', '\345'},
> {'A', 'E', '\306'}, {'a', 'e', '\346'},
> {',', 'C', '\307'}, {',', 'c', '\347'},
> + {'\'', 'C', '\307'}, {'\'', 'c', '\347'},
> {'`', 'E', '\310'}, {'`', 'e', '\350'},
> {'\'', 'E', '\311'}, {'\'', 'e', '\351'},
> {'^', 'E', '\312'}, {'^', 'e', '\352'},
> @@ -259,4 +260,4 @@
> {'s', 'z', '\337'}, {'i', 'j', '\377'},
> };
>
> -unsigned int accent_table_size = 68;
> +unsigned int accent_table_size = 70;
>
> Please undo this patch.
> It is wrong for at least three reasons.
>
> First of all, it is superfluous. If someone needs different
> key assignments he should use loadkeys, not change the kernel.
> Secondly, this file should correspond to defkeymap.map, as the
> first two lines say:
> /* Do not edit this file! It was automatically generated by */
> /* loadkeys --mktable defkeymap.map > defkeymap.c */
> Thirdly, c-cedilla is not the same symbol as c-acute.
> The former is used in French and has Unicode value U+00c7 and U+00e7
> (capital and lower case), the latter is used in Polish and has
> Unicode value U+0106 and U+0107. It is very strange to have
> acute accent combined with C produce a symbol different from C-acute.
>
> Andries

They even look different if one looks closely.

--Marcin

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/