Re: predictable IP ID

kuznet@ms2.inr.ac.ru
Sat, 2 Oct 1999 23:29:03 +0400 (MSK DST)


Hello!

> What do you think about the patch?

Please, add to it the following patchlet. It was my fault.

--- ../T/linux/net/ipv4/raw.c Sat Oct 2 23:04:19 1999
+++ linux/net/ipv4/raw.c Sat Oct 2 13:04:25 1999
@@ -373,7 +373,6 @@
}

rfh.saddr = ipc.addr;
- rfh.dst = &rt->u.dst;
ipc.addr = daddr;

if (!ipc.opt)
@@ -418,6 +417,7 @@

rfh.iov = msg->msg_iov;
rfh.saddr = rt->rt_src;
+ rfh.dst = &rt->u.dst;
if (!ipc.addr)
ipc.addr = rt->rt_dst;
err=ip_build_xmit(sk, sk->protinfo.af_inet.hdrincl ? raw_getrawfrag : raw_getfrag,

BTW why did you restore htons on ident? Is it not useless?
And is ident=1 is really better than 0?

Alexey

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/